Add dependency on datalad_deprecated #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This extension is co-installable with -core, without breaking it -- regardless of whether or not -core still provides some functionality. Due to the age of the crawler, it is likely to be affected most by potential deprecations. Adding this dependency will make it robust against coming changes, such as the `ls` deprecation (datalad/datalad#5569).
Codecov Report
@@ Coverage Diff @@
## master #94 +/- ##
=======================================
Coverage 81.33% 81.33%
=======================================
Files 57 57
Lines 4650 4650
=======================================
Hits 3782 3782
Misses 868 868 Continue to review full report at Codecov.
|
yarikoptic
added
patch
yarikoptic
added a commit
to yarikoptic/datalad-crawler
that referenced
this pull request
Aug 3, 2022
Was introduced in datalad#94 with only hypothetical assumptions of the necessity. We are now hypothesizing that it was not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extension is co-installable with -core, without breaking it --
regardless of whether or not -core still provides some functionality.
Due to the age of the crawler, it is likely to be affected most by
potential deprecations. Adding this dependency will make it robust
against coming changes, such as the
lsdeprecation(datalad/datalad#5569).